Implement SDL 0179 - Pixel density and Scale #1401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amingCapability'.
…nges in the view controller's size to the accepted video resolution divided by the scale.
… Scale' proposal.
…el_density_and_scale
…el_density_and_scale
…deo streaming source match size.
…el_density_and_scale
…from notifications on its own)
smartdevicelink#1360 (comment) smartdevicelink#1360 (comment) update CarWindow and TouchManager to use scale from StreamingVideoLifecycleManager in init smartdevicelink#1360 (comment)
…from notifications on its own)
smartdevicelink#1360 (comment) smartdevicelink#1360 (comment) update private property of tested class in test to meet its declaration
DONE |
fix a typo in string (not an error) Co-Authored-By: NicoleYarroch <[email protected]>
NicoleYarroch
suggested changes
Sep 24, 2019
|
Travis, all tests passed but 2 in the following files: As far as I can see it the 2 are not connected with this subject. |
|
@yLeonid Can you let me know when this is ready to review? The following issues still need to be addressed.
|
…ableItemLocator scale on videoStreamingCapability change. smartdevicelink#1401 (comment)
NicoleYarroch
suggested changes
Sep 27, 2019
…dow and SDLFocusableItemLocator, make it public. smartdevicelink#1401 (comment)
yLeonid
added a commit
to yLeonid/sdl_ios
that referenced
this pull request
Sep 29, 2019
…ct up instead of scaling the point down smartdevicelink#1401 (comment)
…ct up instead of scaling the point down smartdevicelink#1401 (comment)
yLeonid
force-pushed
the
feature/0179_pixel_density_and_scale_v2
branch
from
c9bad4d to
39dac48
Compare
|
Travis tests are not stable, tests sometimes fail |
5 tasks
|
Due to time constraints, we are closing the PR in favor of PR #1420, which was based off of this PR. Thanks for your contributions to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1007
Based on the following PM:
#1360 (reference)
Contributors:
@lnafarrateluxoft
#lnafarrateluxoft
@NicoleYarroch
#NicoleYarroch
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit tests added for:
Functional testing can be done by editing the preferred resolution,
and scale in HMI and testing that the captured view has the proper size and touches are reported
correctly and with the correct coordinates while clicking on the HMI interface.
Also the Automatic Haptic Rect sent to HMI should have the propper size according to the scale value set.
Summary
The main change is related to changing the size of the view captured.
This is done by adding a new scale parameter in the video
streaming capability and by dividing the preferred resolution from the
HMI and the scale.
Also touch coordinates need some changes to match in the HMI with the new resolution, I had to divide the coordinates with the new scale value.
Fixed Travis script to run tests on #Travis CLI
CLA